[improve][cli] Using separate TLS config on the compactor #17426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
force-pushed
the
using-separate-tls-compactor
branch
from
f39a9b7 to
f55d4f5
Compare
|
/pulsarbot rerun-failure-checks |
Signed-off-by: Zixuan Liu <[email protected]>
nodece
force-pushed
the
using-separate-tls-compactor
branch
from
f55d4f5 to
f7874b7
Compare
nodece
requested review from
michaeljmarshall,
nicoloboschi,
codelipenghui,
congbobo184,
Technoboy- and
RobertIndie
4 tasks
michaeljmarshall
pushed a commit
that referenced
this pull request
Sep 29, 2022
Signed-off-by: Zixuan Liu <[email protected]> Signed-off-by: Zixuan Liu <[email protected]> ### Motivation Improve the compactor tool, using separate TLS config ### Modifications - Add separate TLS config on the compactor, both Keystore and PEM formats are supported - Fix correct use of service URL by `brokerConfig.isBrokerClientTlsEnabled()` value ### Verifying this change Test has been added. ### Documentation Check the box below or label this PR directly. Need to update docs? - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [x] `doc-not-needed` (Please explain why) - [ ] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added) (cherry picked from commit 537aa54)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve the compactor tool, using separate TLS config
Modifications
brokerConfig.isBrokerClientTlsEnabled()valueVerifying this change
Test has been added.
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)