Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][test] Add integration test for additional servlets #17450

Merged

Conversation

andrasbeni
Copy link
Contributor

Master Issue: #17132

Motivation

Increase test coverage of additional servlet functionality.

Modifications

  • Created an additional servlet RandomAdditionalServlet.
  • Created a test that configures the additional servlet for the brokers and the proxy and verifies that the servlet functions correctly

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

Added integration tests for additional Servlets

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • doc-not-needed
    This change only affects tests

@andrasbeni
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

1 similar comment
@andrasbeni
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@codelipenghui codelipenghui merged commit e771fc8 into apache:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants