Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][license] Update the jsr version in the presto license file #17461

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

zymap
Copy link
Member

@zymap zymap commented Sep 5, 2022

Motivation

Update the jsr version in the presto license file.

When running license check, it shows:

jsr305-2.0.1.jar mentioned in lib/presto/LICENSE, but not bundled

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@zymap zymap requested a review from Technoboy- September 5, 2022 02:10
@zymap zymap self-assigned this Sep 5, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 5, 2022
@tisonkun
Copy link
Member

tisonkun commented Sep 5, 2022

This refers to #16783.

@zymap zymap added this to the 2.12.0 milestone Sep 5, 2022
---

*Motivation*

Update the jsr version in the presto license file
@Technoboy- Technoboy- force-pushed the update-presto-license-for-jsr305 branch from 9d7d4cc to 4b45945 Compare September 6, 2022 02:00
@Technoboy- Technoboy- closed this Sep 7, 2022
@Technoboy- Technoboy- reopened this Sep 7, 2022
@zymap zymap merged commit e238dcc into apache:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants