[doc] Fix the release process #17470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation There are some wrong steps in the release process and the "Release workflow" section is just a list and hard to verify directly. ### Modifications - Remove the "Move master branch to next version" and "Write release notes" sections because they should be done in the last few steps and they have already been documented. - Add the steps to build Docker images when running the vote. - Skip the release of Helm Chart for patch releases. - Update the step to publish Python clients for macOS because we won't need the VirtualBox after apache#15024. Regenerate the table of contents via `gh-md-toc` to replace the "Release workflow" section. Then we can verify it by clicking the link to the corresponding section.
BewareMyPower
added
the
doc
BewareMyPower
requested review from
merlimat,
Jason918,
Technoboy-,
eolivelli,
codelipenghui,
gaoran10,
Anonymitaet and
mattisonchao
Jason918
reviewed
Sep 5, 2022
Jason918
reviewed
Sep 5, 2022
|
@Jason918 I've updated the documents. PTAL again. |
|
@BewareMyPower This is a great improvement. I think we can send a discuss to mail-list to draw more attentions. |
|
@Jason918 Good suggestion. I have sent an email just now. |
tisonkun
reviewed
Sep 6, 2022
BewareMyPower
changed the title
|
I will continue the release process of 2.8.4 from tomorrow and update this PR as well. |
Jason918
approved these changes
Sep 14, 2022
tisonkun
reviewed
Sep 15, 2022
Comment on lines
+558
to
+559
|
|
||
| git commit -m 'Bumped version to 2.X.Y-SNAPSHOT' -a |
There was a problem hiding this comment.
Suggested change
| git commit -m 'Bumped version to 2.X.Y-SNAPSHOT' -a | |
| git add . | |
| git commit -s -m 'Bumped version to 2.X.Y-SNAPSHOT' |
In case of the files aren't tracked yet.
There was a problem hiding this comment.
No, we should not. Because set-project-version.sh will generate a new temporary file deployment/terraform-ansible/deploy-pulsar.yaml-e and unfortunately it's not included in .gitignore.
There was a problem hiding this comment.
I think we should add them to .gitignore instead, lol. But fair enough to keep as is.
There was a problem hiding this comment.
Yes, we should.
|
@michaeljmarshall @Jason918 I have also adopted your suggestions in the email, see the new Preparation section. |
momo-jun
reviewed
Sep 15, 2022
momo-jun
reviewed
Sep 15, 2022
momo-jun
reviewed
Sep 15, 2022
momo-jun
reviewed
Sep 15, 2022
momo-jun
reviewed
Sep 15, 2022
momo-jun
reviewed
Sep 15, 2022
momo-jun
reviewed
Sep 15, 2022
momo-jun
reviewed
Sep 15, 2022
momo-jun
reviewed
Sep 15, 2022
momo-jun
reviewed
Sep 15, 2022
|
Thanks for your comments @momo-jun, they're addressed now. |
tisonkun
approved these changes
Sep 15, 2022
momo-jun
approved these changes
Sep 15, 2022
codertmy
pushed a commit
to codertmy/pulsar
that referenced
this pull request
Sep 16, 2022
### Motivation There are some wrong steps in the release process and the "Release workflow" section is just a list and hard to verify directly. ### Modifications - Remove the "Move master branch to next version" and "Write release notes" sections because they should be done in the last few steps and they have already been documented. - Add the steps to build Docker images when running the vote. - Skip the release of Helm Chart for patch releases. - Update the step to publish Python clients for macOS because we won't need the VirtualBox after apache#15024. Regenerate the table of contents via `gh-md-toc` to replace the "Release workflow" section. Then we can verify it by clicking the link to the corresponding section.
1 task
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are some wrong steps in the release process and the "Release
workflow" section is just a list and hard to verify directly.
Modifications
the release process.
notes" sections because they should be done in the last few steps and
they have already been documented.
the following step by just copying approved candidate images from the
personal account to the official apachepulsar account.
need the VirtualBox after [Python] Added script to generate Wheel files for MacOS #15024.
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)