[fix][broker] Extract additional servlets to the default directory by… #17477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
reviewed
Sep 5, 2022
| @@ -23,6 +23,7 @@ | |||
| import java.util.Map; | |||
| import lombok.Getter; | |||
| import lombok.extern.slf4j.Slf4j; | |||
| import org.apache.commons.lang.StringUtils; | |||
There was a problem hiding this comment.
Please use org.apache.commons.lang3.StringUtils instead of org.apache.commons.lang.StringUtils
hangc0276
approved these changes
Sep 6, 2022
codelipenghui
approved these changes
Sep 6, 2022
codelipenghui
added
type/bug
gaoran10
approved these changes
Sep 6, 2022
|
/pulsarbot rerun-failure-checks |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
@codelipenghui , do I need to rebase this PR and test it in my own fork, or can it be merged without all that? |
Technoboy-
pushed a commit
that referenced
this pull request
Sep 26, 2022
2 tasks
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 10, 2023
apache#17477) (cherry picked from commit 3d47ee8) (cherry picked from commit ffe0a22)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 11, 2023
apache#17477) (cherry picked from commit 3d47ee8) (cherry picked from commit ffe0a22)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… default
Fixes #17472
Motivation
AdditionalServlets.loaddoes not use the default value ofnarExtractionDirectorywhen the property is set to an empty string (which is the default inconf/broker.conf).Modifications
Similar to
FieldParser.update, empty string and null are made equivalent to AdditionalServlets.Verifying this change
This change can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-not-neededThis is a bugfix