Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][cpp] Use weak ptr avoid circular references. #17481

Merged
merged 3 commits into from
Sep 22, 2022
Merged

[fix][cpp] Use weak ptr avoid circular references. #17481

merged 3 commits into from
Sep 22, 2022

Conversation

shibd
Copy link
Member

@shibd shibd commented Sep 6, 2022 •
edited
Loading

Motivation

Capturing shared ptr in the timer function will cause a circular reference.

Modifications

  • Use weak ptr instead shared ptr.

Documentation

  • doc-not-needed

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 6, 2022
@shibd shibd requested a review from BewareMyPower September 13, 2022 01:52
@shibd shibd closed this Sep 14, 2022
@shibd shibd reopened this Sep 14, 2022
@BewareMyPower
Copy link
Contributor

Please rebase to master to have some CI fixes.

@RobertIndie RobertIndie merged commit 141981b into apache:master Sep 22, 2022
@shibd shibd mentioned this pull request Oct 27, 2022
Merged
5 tasks
congbobo184 pushed a commit that referenced this pull request Nov 14, 2022
@shibd
[fix][cpp] Use weak ptr avoid circular references. (#17481)
3516e27 
### Motivation

Capturing shared ptr in the timer function will cause a circular reference.

### Modifications

- Use weak ptr instead shared ptr.

(cherry picked from commit 141981b)
@congbobo184 congbobo184 added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Nov 14, 2022
congbobo184 pushed a commit that referenced this pull request Dec 7, 2022
@shibd
[fix][cpp] Use weak ptr avoid circular references. (#17481)
8036bd0 
### Motivation

Capturing shared ptr in the timer function will cause a circular reference.

### Modifications

- Use weak ptr instead shared ptr.

(cherry picked from commit 141981b)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 10, 2023
@shibd @nicoloboschi
[fix][cpp] Use weak ptr avoid circular references. (apache#17481)
fed368c 
### Motivation

Capturing shared ptr in the timer function will cause a circular reference.

### Modifications

- Use weak ptr instead shared ptr.

(cherry picked from commit 141981b)
(cherry picked from commit 6bbaf16)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 11, 2023
@shibd @nicoloboschi
[fix][cpp] Use weak ptr avoid circular references. (apache#17481)
843fe6e 
### Motivation

Capturing shared ptr in the timer function will cause a circular reference.

### Modifications

- Use weak ptr instead shared ptr.

(cherry picked from commit 141981b)
(cherry picked from commit 6bbaf16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BewareMyPower BewareMyPower BewareMyPower approved these changes

@RobertIndie RobertIndie RobertIndie approved these changes

Assignees

@shibd shibd

Labels
cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 doc-not-needed Your PR changes do not impact docs release/2.8.5 release/2.9.4 release/2.10.3 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shibd @BewareMyPower @RobertIndie @Technoboy- @congbobo184 @liangyepianzhou