Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imporve][doc] Update cluster failover document #17489

Merged
merged 6 commits into from
Sep 9, 2022

Conversation

labuladong
Copy link
Contributor

Fixes #17433

Modification

Create a new chapter "Cluster-level failover" behind the Geo-Replication chapter and only keep code demos in Java doc.

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Sep 6, 2022
@labuladong labuladong marked this pull request as ready for review September 8, 2022 02:56
@labuladong
Copy link
Contributor Author

cc @momo-jun @Anonymitaet

@tisonkun
Copy link
Member

tisonkun commented Sep 8, 2022

@labuladong if this patch is ready for review, you can remove the "WIP:" prefix. And I suggest that you use Draft PR mechanism to state status.

@labuladong labuladong changed the title WIP: Update cluster failover document [imporve][doc] Update cluster failover document Sep 8, 2022
Copy link
Member

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Before submitting a doc PR, please preview your changes locally. When submitting a PR, please attach screenshots of your local preview. In this way, you can get your PR reviewed and merged more quickly.

Thank you! 😊

site2/docs/client-libraries-java.md Outdated Show resolved Hide resolved
@labuladong
Copy link
Contributor Author

@momo-jun @Anonymitaet Thanks for your review! Screenshots:

image

image

image

@labuladong
Copy link
Contributor Author

All tests passed. Could you help to merge this pr? @Anonymitaet

@momo-jun momo-jun merged commit 200f433 into apache:master Sep 9, 2022
@labuladong labuladong deleted the update-cluster-failover branch September 9, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] Cluster-level failover shouldn't be part of Java client chapter
4 participants