[improve][admin]namespace CLI set-offload-policy's thresholdBytes support negative and 0 #17502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Technoboy- @zymap @hangc0276 PTAL. |
ethqunzhong
changed the title
zymap
approved these changes
Sep 7, 2022
|
/pulsarbot run-failure-checks |
|
@hangc0276 @zymap @Technoboy- This patch is ready to merge. PTAL. |
|
/pulsarbot run-failure-checks |
ethqunzhong
requested review from
zymap
and removed request for
hangc0276 and
Technoboy-
|
it seems pass all CI, ready to merged. PTAL @zymap |
Technoboy-
approved these changes
Sep 13, 2022
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
@Technoboy- ready to merged. PTAL |
|
@codelipenghui ready to merged. PTAL |
hangc0276
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
we could set namespace level offload-policy's offload-threshold In the following two
pulsar-admin CLIways:pulsar-admin namespaces set-offload-threshold -s $OFFLOAD_THRESHOLD demo/demopulsar-admin namespaces set-offload-policies --offloadAfterThreshold $OFFLOAD_THRESHOLD demo/demowhile set offload-threshold value , Negative values disable automatic offload. 0 triggers offloading as soon as possible.
but we can't use
pulsar-admin namespaces set-offload-policiesto set offload-threshold'value to negative or 0 , show as follow：pulsar-admin namespaces set-offload-thresholdas expected.we should keep
set-offload-thresholdandset-offload-policiesCLI behavior consistent.Modifications
remove
positiveCheckprocess while check offloadAfterThreshold value validity atCmdNamespaces#SetOffloadPolicies.Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)