Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][managed-ledger]fix typo error in ManagedCursorContainer #17509

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

HQebupt
Copy link
Contributor

@HQebupt HQebupt commented Sep 7, 2022

Motivation

fix typo error in ManagedCursorContainer

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

@HQebupt Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@HQebupt
Copy link
Contributor Author

HQebupt commented Sep 9, 2022

/pulsarbot run-failure-checks

@lhotari
Copy link
Member

lhotari commented Sep 9, 2022

/pulsarbot run-failure-checks

@HQebupt This won't help. please read https://lists.apache.org/thread/lv358906mnroq7tkk72xtsxfyjpbyvor . This PR won't be eligible for merging unless you rebase.

@HQebupt
Copy link
Contributor Author

HQebupt commented Sep 9, 2022

/pulsarbot run-failure-checks

@HQebupt This won't help. please read https://lists.apache.org/thread/lv358906mnroq7tkk72xtsxfyjpbyvor . This PR won't be eligible for merging unless you rebase.

I see, thanks

@AnonHxy AnonHxy added the doc-not-needed Your PR changes do not impact docs label Sep 23, 2022
@momo-jun momo-jun added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-not-needed Your PR changes do not impact docs doc-label-missing labels Sep 29, 2022
@github-actions github-actions bot added doc-label-missing and removed doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels Sep 29, 2022
@github-actions
Copy link

@HQebupt Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@momo-jun momo-jun added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-label-missing labels Sep 29, 2022
@github-actions github-actions bot added doc-label-missing doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. doc-label-missing labels Sep 29, 2022
@AnonHxy AnonHxy closed this Sep 30, 2022
@AnonHxy AnonHxy reopened this Sep 30, 2022
@HQebupt
Copy link
Contributor Author

HQebupt commented Sep 30, 2022

/pulsarbot run-failure-checks

@AnonHxy AnonHxy merged commit 2891d5c into apache:master Sep 30, 2022
@AnonHxy AnonHxy changed the title [cleanup][managed-ledger]fix typo error in ManagedCursorContainer [fix][managed-ledger]fix typo error in ManagedCursorContainer Sep 30, 2022
@AnonHxy AnonHxy added this to the 2.12.0 milestone Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants