Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][test] Add integration test for broker interceptors #17515

Merged
merged 6 commits into from
Sep 21, 2022
Merged

[improve][test] Add integration test for broker interceptors #17515

merged 6 commits into from
Sep 21, 2022

Conversation

andrasbeni
Copy link
Contributor

@andrasbeni andrasbeni commented Sep 7, 2022 •
edited
Loading

Running tests at: andrasbeni#2

Master Issue: #17132

Motivation

Increase test coverage of broker interceptor functionality.

Modifications

  • Created broker interceptor LoggingBrokerInterceptor.
  • Created a test that configures the interceptor for the broker and verifies through the broker log that the interceptor's methods are called

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

Added integration tests for broker interceptors

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • doc-not-needed
    This change only affects tests

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 7, 2022
@andrasbeni
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@codelipenghui codelipenghui mentioned this pull request Sep 11, 2022
Closed
10 tasks
@andrasbeni
Copy link
Contributor Author

/pulsarbot run-failure-checks

@andrasbeni andrasbeni closed this Sep 14, 2022
@andrasbeni andrasbeni reopened this Sep 14, 2022
@andrasbeni
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@andrasbeni
Copy link
Contributor Author

/pulsarbot run-failure-checks

@andrasbeni andrasbeni mentioned this pull request Sep 19, 2022
Closed
@merlimat
Copy link
Contributor

/pulsarbot rerun-failure-checks

@andrasbeni andrasbeni closed this Sep 20, 2022
@andrasbeni andrasbeni reopened this Sep 20, 2022
@codelipenghui codelipenghui added this to the 2.12.0 milestone Sep 20, 2022
@andrasbeni
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@Technoboy- Technoboy- merged commit bb98333 into apache:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@lhotari lhotari lhotari approved these changes

@merlimat merlimat merlimat approved these changes

Assignees

@andrasbeni andrasbeni

Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@andrasbeni @merlimat @lhotari @codelipenghui @Technoboy-