[fix][broker] Fix potential exception causing the reader to be unable to continue reading #17556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Sep 9, 2022
merlimat
approved these changes
Sep 9, 2022
merlimat
added
type/bug
Technoboy-
added
release/2.9.4
release/2.8.5
release/2.7.6
release/2.10.3
and removed
cherry-picked/branch-2.10
labels
Technoboy-
added a commit
that referenced
this pull request
Sep 10, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Sep 13, 2022
(cherry picked from commit 12a6cc4)
mattisonchao
pushed a commit
that referenced
this pull request
Sep 13, 2022
(cherry picked from commit 12a6cc4)
zymap
pushed a commit
that referenced
this pull request
Sep 15, 2022
(cherry picked from commit 12a6cc4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If
refreshTopicPoliciesCache(msg)throws any RuntimeException, the policy reader will stop to read messages anymore.Modification
Move
refreshTopicPoliciesCacheto be execute intothenAccept.Documentation
doc-not-needed(Please explain why)