[fix][broker] Fix potential can't remove producer/reader reference #17559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested changes
Sep 9, 2022
...r-broker/src/main/java/org/apache/pulsar/broker/systopic/TopicPoliciesSystemTopicClient.java
Outdated
Show resolved
Hide resolved
...r-broker/src/main/java/org/apache/pulsar/broker/systopic/TopicPoliciesSystemTopicClient.java
Outdated
Show resolved
Hide resolved
lhotari
approved these changes
Sep 10, 2022
HQebupt
approved these changes
Sep 12, 2022
| } | ||
|
|
||
| @Override | ||
| public CompletableFuture<Void> closeAsync() { | ||
| return reader.closeAsync().thenCompose(v -> { |
There was a problem hiding this comment.
This line is key point. The previous thenCompose is replaced by thenApply just to save CompletableFuture. Right?
mattisonchao
approved these changes
Sep 13, 2022
Technoboy-
added a commit
that referenced
this pull request
Sep 13, 2022
tisonkun
pushed a commit
to tisonkun/pulsar
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the
producer/readerclose with the exception, there may exist references that can't remove from the list.Documentation
doc-not-needed(Please explain why)