[fix][broker] Topic policy reader can't recover when get any exception. #17562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c28444c.
This reverts commit 64165c5.
mattisonchao
commented
Sep 9, 2022
| initPolicesCache(reader, result); | ||
| result.thenRun(() -> readMorePolicies(reader)); | ||
| } | ||
| readerCompletableFuture.thenAccept(reader -> { |
There was a problem hiding this comment.
Use thenAccept to avoid using the null value in whenComplete again. because we will pass the result future to the next operation. So, we don't need thenCompose
| if (ex != null) { | ||
| log.error("[{}] Failed to create reader on __change_events topic", namespace, ex); | ||
| result.completeExceptionally(ex); | ||
| cleanCacheAndCloseReader(reader.getSystemTopic().getTopicName().getNamespaceObject(), false); |
There was a problem hiding this comment.
In the current time reader is null, So we can't clean the cache and close the reader.
| result.thenRun(() -> readMorePolicies(reader)); | ||
| }).exceptionally(ex -> { | ||
| log.error("[{}] Failed to create reader on __change_events topic", namespace, ex); | ||
| cleanCacheAndCloseReader(namespace, false); |
There was a problem hiding this comment.
This method won't have any chance to throw an exception. I think it's safe enough and don't need try-catch.
| readerFuture.thenAccept(SystemTopicClient.Reader::closeAsync); | ||
| readerFuture.thenCompose(SystemTopicClient.Reader::closeAsync) | ||
| .exceptionally(ex -> { | ||
| log.warn("[{}] Close change_event reader fail.", namespace, ex); |
There was a problem hiding this comment.
We can add a log to help debug. Maybe we can introduce more mechanisms to clean up the resource. But it's not the current PR focus.
Technoboy-
approved these changes
Sep 9, 2022
Jason918
approved these changes
Sep 9, 2022
codelipenghui
approved these changes
Sep 13, 2022
Technoboy-
pushed a commit
that referenced
this pull request
Sep 13, 2022
tisonkun
pushed a commit
to tisonkun/pulsar
that referenced
this pull request
Sep 14, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 16, 2022
apache#17562) (cherry picked from commit 5aa1f11) (cherry picked from commit c844c20)
dragonls
pushed a commit
to dragonls/pulsar
that referenced
this pull request
Oct 21, 2022
apache#17562) (cherry picked from commit 5aa1f11)
dragonls
pushed a commit
to dragonls/pulsar
that referenced
this pull request
Oct 21, 2022
…rge request !44) [fix][broker] Topic policy reader can't recover when get any exception (apache#17562)
touchkey
pushed a commit
to sajithsebastian/pulsar
that referenced
this pull request
May 24, 2023
apache#17562) (cherry picked from commit 5aa1f11)
touchkey
pushed a commit
to sajithsebastian/pulsar
that referenced
this pull request
May 26, 2023
…exception (apache#17562)" This reverts commit c3b49ae.
|
@mattisonchao @zymap Do we have any plan to release 2.8.5 shortly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15891
Motivation
When creating the topic policy reader got any problem(maybe a network problem), and we can not clear the current state, which will let the broker can not retry to init the topic policy reader again until we unload the namespace.
Modifications
Verifying this change
I think it's not a logical error. we don't need to add the unit test.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)