Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][doc] Remove redundant steps in doc generation #17585

Merged
merged 5 commits into from
Sep 23, 2022

Conversation

SignorMercurio
Copy link
Contributor

@SignorMercurio SignorMercurio commented Sep 12, 2022

Matching PR in forked repository

SignorMercurio#3

Motivation

Docs for Pulsar CLI tools such as pulsar-admin, pulsar-client, pulsar and pulsar-perf are auto-generated but contains redundant steps that will produce complex but not useful TOCs(table of content). This PR aims to remove these steps.

Modifications

Remove all ---, Usage and bdocs-tab:example_shell parts since they are no longer useful.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Sep 12, 2022
Signed-off-by: Mercurio <[email protected]>
Signed-off-by: Mercurio <[email protected]>
Signed-off-by: Mercurio <[email protected]>
@SignorMercurio
Copy link
Contributor Author

/pulsarbot run-failure-checks

Signed-off-by: Mercurio <[email protected]>
@Anonymitaet Anonymitaet merged commit 4366f28 into apache:master Sep 23, 2022
@SignorMercurio SignorMercurio deleted the docs/remove-redund branch September 23, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants