Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][misc] CI status on README.md #17590

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Conversation

tisonkun
Copy link
Member

Motivation & Modification

  1. We don't run Pulsar CI for the master branch, so although we can add a badge for it ci, it's inaccurate.
  2. Docker build workflow name has been changed. Also, the workflow doesn't reflect a useful status. Replace it with docker pull statistics.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

cc @lhotari @Anonymitaet

1. We don't run Pulsar CI for the master branch, so although we can add a badge for it [![ci](https://github.com/apache/pulsar/actions/workflows/pulsar-ci.yaml/badge.svg)](https://github.com/apache/pulsar/actions/workflows/pulsar-ci.yaml), it's inaccurate.
2. Docker build workflow name has been changed. Also, the workflow doesn't reflect a useful status. Replace it with docker pull statistics.
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Sep 12, 2022
@nicoloboschi nicoloboschi merged commit af3956c into apache:master Sep 12, 2022
@tisonkun tisonkun deleted the patch-1 branch September 12, 2022 23:50
@Anonymitaet Anonymitaet added this to the 2.12.0 milestone Sep 13, 2022
@Anonymitaet
Copy link
Member

Thanks! @tisonkun

cc @SignorMercurio

@momo-jun momo-jun modified the milestones: 2.12.0, 2.11.0 Sep 13, 2022
tisonkun added a commit to tisonkun/pulsar that referenced this pull request Sep 14, 2022
1. We don't run Pulsar CI for the master branch, so although we can add a badge for it [![ci](https://github.com/apache/pulsar/actions/workflows/pulsar-ci.yaml/badge.svg)](https://github.com/apache/pulsar/actions/workflows/pulsar-ci.yaml), it's inaccurate.
2. Docker build workflow name has been changed. Also, the workflow doesn't reflect a useful status. Replace it with docker pull statistics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants