[improve][broker] Make log flushing configurable in Pulsar broker #17591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- by default Pulsar won't flush log statements to disk after each log line. This is problematic while investigating some issues since the broker might crash without the last log lines.
github-actions
bot
added
the
doc-required
merlimat
approved these changes
Sep 12, 2022
michaeljmarshall
approved these changes
Sep 13, 2022
tisonkun
pushed a commit
to tisonkun/pulsar
that referenced
this pull request
Sep 14, 2022
…ache#17591) - by default Pulsar won't flush log statements to disk after each log line. This is problematic while investigating some issues since the broker might crash without the last log lines.
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Sep 19, 2022
…ache#17591) - by default Pulsar won't flush log statements to disk after each log line. This is problematic while investigating some issues since the broker might crash without the last log lines. (cherry picked from commit e79642c)
|
@lhotari does this improvement have any user impact? If yes, it would help users better understand this improvement with the required docs. Do you have any plans for updating the docs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Make it possible to override the default setting with PULSAR_LOG_IMMEDIATE_FLUSH environment variable.
Setting
PULSAR_LOG_IMMEDIATE_FLUSH=truewould make logging to flush the logging buffer after each log statement.Additional context
immediateFlush option documentation: https://logging.apache.org/log4j/2.x/manual/appenders.html#RollingFileAppender
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)