Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][functions] Fix K8S download function method with auth enabled #17597

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

nicoloboschi
Copy link
Contributor

Motivation

After dab0d1f#diff-534a0ee16ee831fd0f16fa1230ff3a6e24f6428abd378790f821867f2ec1ffb0R891 , functions deployed with KubernetesRuntimeFactory doesn't work if the authentication is enabled between components.

Was passed main parameter '--auth-plugin' but no main parameter was defined in your arg class
Download File Data from Pulsar
Usage: download [options]
  Options:
    --destination-file
      The file to store downloaded content
    --fqfn
      The Fully Qualified Function Name (FQFN) for the function
    --name
      The name of a Pulsar Function
    --namespace
      The namespace of a Pulsar Function
    --tenant
      The tenant of a Pulsar Function
    --transform-function
      Download the transform Function of the connector
      Default: false

Note that this regression is only on current master branch.

Modifications

  • Set the auth options as pulsar-admin CLI commands instead of functions download options
  • Added a test
  • doc-not-needed

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 12, 2022
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good.

@eolivelli eolivelli modified the milestones: 2.12.0, 2.11.0 Sep 13, 2022
@eolivelli eolivelli added area/function release/blocker Indicate the PR or issue that should block the release until it gets resolved and removed release/blocker Indicate the PR or issue that should block the release until it gets resolved labels Sep 13, 2022
@eolivelli eolivelli modified the milestones: 2.11.0, 2.12.0 Sep 13, 2022
@eolivelli eolivelli merged commit d23b760 into apache:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/function doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants