-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][pulsar-proxy] Update proxy lookup throw exception type #17600
Merged
tuteng
merged 1 commit into
apache:master
from
AmateurEvents:fixed/update-proxy-lookup-exception-type
Sep 14, 2022
Merged
[improve][pulsar-proxy] Update proxy lookup throw exception type #17600
tuteng
merged 1 commit into
apache:master
from
AmateurEvents:fixed/update-proxy-lookup-exception-type
Sep 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuteng
requested review from
BewareMyPower,
codelipenghui,
merlimat and
nodece
September 13, 2022 02:43
tuteng
added
cherry-picked/branch-2.9
Archived: 2.9 is end of life
cherry-picked/branch-2.10
cherry-picked/branch-2.11
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
labels
Sep 13, 2022
nodece
reviewed
Sep 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
nodece
approved these changes
Sep 13, 2022
Technoboy-
added
area/proxy
release/2.9.4
release/2.11.1
release/2.10.3
and removed
cherry-picked/branch-2.9
Archived: 2.9 is end of life
cherry-picked/branch-2.10
cherry-picked/branch-2.11
labels
Sep 13, 2022
Technoboy-
approved these changes
Sep 13, 2022
merlimat
approved these changes
Sep 14, 2022
BewareMyPower
approved these changes
Sep 14, 2022
tisonkun
pushed a commit
to tisonkun/pulsar
that referenced
this pull request
Sep 14, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Sep 19, 2022
(cherry picked from commit 52a380f)
codelipenghui
pushed a commit
that referenced
this pull request
Sep 19, 2022
(cherry picked from commit 52a380f)
codelipenghui
pushed a commit
that referenced
this pull request
Sep 19, 2022
(cherry picked from commit 52a380f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/proxy
cherry-picked/branch-2.9
Archived: 2.9 is end of life
cherry-picked/branch-2.10
cherry-picked/branch-2.11
doc-not-needed
Your PR changes do not impact docs
release/2.9.4
release/2.10.2
release/2.11.1
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Master Issue: #
Motivation
Currently most of the exceptions after proxy lookup throw service not ready, but some clients do not handle this exception, when the user encounters an authentication error, the client will receive the serviceNotReady exception, which makes the user confused
So use getServerError to wrap the exception to avoid always throwing serviceNotReady exception when encountering an exception
Modifications
Use getServerError to wrap the exception to avoid always throwing serviceNotReady exception when encountering an exception
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
This is some unusual optimization, which does not require a change in the documentation
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)