Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][pulsar-proxy] Update proxy lookup throw exception type #17600

Merged

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented Sep 13, 2022

Fixes #

Master Issue: #

Motivation

Currently most of the exceptions after proxy lookup throw service not ready, but some clients do not handle this exception, when the user encounters an authentication error, the client will receive the serviceNotReady exception, which makes the user confused
So use getServerError to wrap the exception to avoid always throwing serviceNotReady exception when encountering an exception

Modifications

Use getServerError to wrap the exception to avoid always throwing serviceNotReady exception when encountering an exception

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    This is some unusual optimization, which does not require a change in the documentation

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@tuteng tuteng self-assigned this Sep 13, 2022
@tuteng tuteng added cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 cherry-picked/branch-2.11 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels Sep 13, 2022
Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tuteng tuteng merged commit 52a380f into apache:master Sep 14, 2022
tisonkun pushed a commit to tisonkun/pulsar that referenced this pull request Sep 14, 2022
codelipenghui pushed a commit that referenced this pull request Sep 19, 2022
codelipenghui pushed a commit that referenced this pull request Sep 19, 2022
codelipenghui pushed a commit that referenced this pull request Sep 19, 2022
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Sep 19, 2022
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Sep 20, 2022
(cherry picked from commit 52a380f)
(cherry picked from commit 9fecb9e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/proxy cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 cherry-picked/branch-2.11 doc-not-needed Your PR changes do not impact docs release/2.9.4 release/2.10.2 release/2.11.1 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants