Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][doc] improve pulsar I/O document #17601

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

labuladong
Copy link
Contributor

Fixes #17555

Motivation

At first, I'd like to fix the broken links in Pulsar I/O chapter. But I found that not only this chapter has this problem, so I open #17599 for further discussion.

In this PR, I replace the docker introduction with a reference link and improve some code snippets.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Sep 13, 2022
@labuladong
Copy link
Contributor Author

cc @Anonymitaet @momo-jun

Copy link
Member

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
I've left some comments, PTAL.
Feel free to correct me if my understanding is inaccurate and let me know if you have any concerns. 😊

site2/docs/io-quickstart.md Outdated Show resolved Hide resolved
@Anonymitaet Anonymitaet added this to the 2.11.0 milestone Sep 13, 2022
@labuladong
Copy link
Contributor Author

Thanks for your review, changes were addressed. @Anonymitaet @momo-jun

@momo-jun momo-jun merged commit 91f484f into apache:master Sep 14, 2022
@labuladong labuladong deleted the fix-io-broken-link branch September 14, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] There are many broken links in Pulsar IO chapter
4 participants