Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[monitoring][broker][fix] Fix EntryFilter stats #17605

Merged
merged 4 commits into from
Sep 21, 2022
Merged

[monitoring][broker][fix] Fix EntryFilter stats #17605

merged 4 commits into from
Sep 21, 2022

Conversation

tjiuming
Copy link
Contributor

Fixes #17595

Motivation

Fix #17595 when no EntryFilters configured

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@tjiuming tjiuming mentioned this pull request Sep 13, 2022
Closed
2 tasks
@tjiuming
Copy link
Contributor Author

@michaeljmarshall @codelipenghui PTAL

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 13, 2022
gaoran10
gaoran10 reviewed Sep 13, 2022
View reviewed changes
Copy link
Contributor

@gaoran10 gaoran10 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it seems that there is a potential problem, if there are some markers, the filterProcessCount will be not equal with rejectedCount + rescheduledCount + acceptCount, which may cause misunderstanding.

@tjiuming
Copy link
Contributor Author

tjiuming commented Sep 13, 2022 •
edited
Loading

if there are some markers, the filterProcessCount will be not equal with rejectedCount + rescheduledCount + acceptCount, which may cause misunderstanding.

@gaoran10 could you please describe more clearly?

gaoran10
gaoran10 approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@gaoran10 gaoran10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nicoloboschi
nicoloboschi approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just a nit for avoiding to call Collections.isEmpty multiple times

pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractBaseDispatcher.java Outdated Show resolved Hide resolved
@tjiuming
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@nicoloboschi nicoloboschi merged commit 8441f67 into apache:master Sep 21, 2022
@nicoloboschi nicoloboschi added this to the 2.12.0 milestone Sep 21, 2022
Technoboy- pushed a commit that referenced this pull request Sep 26, 2022
@tjiuming @Technoboy-
[monitoring][broker][fix] Fix EntryFilter stats (#17605)
bc0acb9 
* fix entryFilter stats

* fix test

* add test comment

* review fix
@Technoboy- Technoboy- modified the milestones: 2.12.0, 2.11.0 Sep 26, 2022
@tjiuming tjiuming deleted the fix/entry_filter_stats_fix branch November 1, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoloboschi nicoloboschi nicoloboschi approved these changes

@gaoran10 gaoran10 gaoran10 approved these changes

Assignees

@tjiuming tjiuming

Labels
area/metrics cherry-picked/branch-2.11 doc-not-needed Your PR changes do not impact docs
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

[Bug] Entry filters stats should not be increased if there's no entry filter
5 participants
@tjiuming @gaoran10 @nicoloboschi @Technoboy- @dao-jun