Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][test] Add integration test for pulsar-client #17616

Merged
merged 3 commits into from
Sep 21, 2022

Conversation

andrasbeni
Copy link
Contributor

@andrasbeni andrasbeni commented Sep 13, 2022

Master Issue: #17132

Motivation

Increase test coverage of the command line tool pulsar-client.

Modifications

Created a test that runs the pulsar-client tool to produce messages. Then checks if the messages have been produced by consuming with the same tool.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

Added integration tests for broker interceptors

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • doc-not-needed
    This change only affects tests

PR in forked repository: andrasbeni#1

@andrasbeni andrasbeni closed this Sep 13, 2022
@andrasbeni andrasbeni reopened this Sep 13, 2022
@andrasbeni
Copy link
Contributor Author

/pulsarbot run-failure-checks

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 14, 2022
@andrasbeni
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui added this to the 2.12.0 milestone Sep 16, 2022
@codelipenghui codelipenghui added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/test labels Sep 16, 2022
@Technoboy- Technoboy- merged commit 68c7549 into apache:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test doc-not-needed Your PR changes do not impact docs ready-to-test type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants