[fix][cli] Pulsar shell: ensure admin client is recycled or disposed #17619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
Sep 13, 2022
nodece
reviewed
Sep 14, 2022
| Boolean tlsAllowInsecureConnection; | ||
| String tlsTrustCertsFilePath; | ||
| Boolean tlsEnableHostnameVerification; | ||
| String tlsProvider; |
There was a problem hiding this comment.
Miss the TLS transport config here, let me make a PR to do that.
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
Sep 16, 2022
…pache#17619) * [fix][cli] Pulsar shell: ensure admin client is recycled or disposed (cherry picked from commit 1ff9fb6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In Pulsar shell when creating a new admin client (using the
adminAPI) is created for each command. There are two considerations:Modifications
PulsarAdminTool) in order to being able to compare configurations and decide to keep or destroy the current admin clientThe client is discarded when:
--admin-url) that is different from the current oneconfig use ...) without the comparison because a newPulsarAdminToolis created. This makes sense because when you change the config, you change the tenant or cluster.doc-not-needed