Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup][client]Removing null-check finalEx in ProducerImpl.OpSendMsg.sendComplete #17624

Merged
merged 1 commit into from
Sep 14, 2022
Merged

[cleanup][client]Removing null-check finalEx in ProducerImpl.OpSendMsg.sendComplete #17624

merged 1 commit into from
Sep 14, 2022

Conversation

AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Sep 13, 2022 •
edited
Loading

Motivation

Removing check finalEx is null, because condition finalEx != null covered by subsequent condition finalEx instanceof TimeoutException

Modifications

Removing condition finalEx != null

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@AnonHxy AnonHxy self-assigned this Sep 13, 2022
@AnonHxy AnonHxy changed the title [improve][client]Remove null-check finalEx [improve][client]Removing null-check finalEx in ProducerImpl.OpSendMsg.sendComplete Sep 13, 2022
@AnonHxy AnonHxy changed the title [improve][client]Removing null-check finalEx in ProducerImpl.OpSendMsg.sendComplete [cleanup][client]Removing null-check finalEx in ProducerImpl.OpSendMsg.sendComplete Sep 13, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 13, 2022
@merlimat merlimat added this to the 2.12.0 milestone Sep 14, 2022
@merlimat merlimat added the type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use label Sep 14, 2022
@merlimat merlimat merged commit e4a1473 into apache:master Sep 14, 2022
tisonkun pushed a commit to tisonkun/pulsar that referenced this pull request Sep 14, 2022
@AnonHxy @tisonkun
Remove null-check finalEx (apache#17624)
eee44f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

Assignees

@AnonHxy AnonHxy

Labels
doc-not-needed Your PR changes do not impact docs type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AnonHxy @merlimat