Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][test] Improve the ClusterMetadataSetupTest to reduce the execution time #17627

Merged

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Sep 14, 2022

Fixes #17621

Modifications

Only start the ZooKeeper once and clean the ZooKeeper data after the end of each test execution.
And clean useless methods stop().

Execution time after improve test:

[INFO] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 47.734 s - in org.apache.pulsar.broker.zookeeper.ClusterMetadataSetupTest

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 14, 2022
Copy link
Contributor

@poorbarcode poorbarcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@codelipenghui codelipenghui added this to the 2.12.0 milestone Sep 15, 2022
@codelipenghui codelipenghui added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/test labels Sep 15, 2022
@codelipenghui codelipenghui merged commit 25cb1fb into apache:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slowly-test: ClusterMetadataSetupTest
3 participants