[improve][broker] Cancel the loadShedding task when closing pulsar service #17632
+97
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
requested review from
eolivelli,
Jason918,
lhotari,
codelipenghui,
congbobo184,
mattisonchao,
Technoboy- and
zymap
gaoran10
changed the title
poorbarcode
approved these changes
Sep 14, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LoadSheddingTask.java
Show resolved
Hide resolved
congbobo184
approved these changes
Sep 14, 2022
pulsar-broker/src/test/java/org/apache/pulsar/broker/PulsarServiceCloseTest.java
Show resolved
Hide resolved
codelipenghui
added
release/2.10.2
release/blocker
pulsar-broker/src/test/java/org/apache/pulsar/broker/PulsarServiceCloseTest.java
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/PulsarServiceCloseTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/PulsarServiceCloseTest.java
Outdated
Show resolved
Hide resolved
Technoboy-
approved these changes
Sep 15, 2022
coderzc
approved these changes
Sep 15, 2022
Technoboy-
pushed a commit
that referenced
this pull request
Sep 15, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 20, 2022
…rvice (apache#17632) (cherry picked from commit cbbcd41) (cherry picked from commit 9a1f483)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The PR #16408 supported loadBalancerSheddingIntervalMinutes dynamic configuration, but the scheduled load-shedding task may block pulsar service close operation, the pulsar service need to wait until the scheduled load-shedding task executed or reach broker shutdown timeout. If the load-shedding task interval time and broker shutdown timeout are long, the pulsar service close operation will waste a lot of time.
Modifications
Cancel the scheduled task when closing the pulsar service.
Verifying this change
Add a test to verify the pulsar service could be closed gracefully in time.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)