[fix][cli] Pulsar shell: support relative paths (cliextensions) #17648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Sep 15, 2022
There was a problem hiding this comment.
This is tricky.
because with this change all the references to files in pulsar-admin commands will be relative to PULSAR_HOME and not to the current user directory.
The behaviour should be consistent with pulsar-admin when launched from the command line.
Maybe we can do this change (my understanding is that we already do it for pulsar-admin), but we have to enhance pulsar-admin commands that accept relative paths to pick them from the current directory and not from the Pulsar home)
|
@eolivelli all the other scripts behave this way Line 25 in 98cf15f I agree that is not optimal but it's better to be consistent and do (if needed) the change for each script in the same pull request |
eolivelli
approved these changes
Sep 15, 2022
Merged
1 task
Technoboy-
pushed a commit
that referenced
this pull request
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
pulsar-shellscript doesn't change the working directory to the Pulsar home one. In this way if you configurecliExtensionsDirectorywith a relative path, it only works if you run pulsar-shell from the pulsar home directory. For instancecd bin && ./pulsar-shellis not able to find the cli extensions dir.Modifications
The only disadvantage is that the
--fileautocompletion will suggest files from the Pulsar home directory and not fromthe real working dir. (but it's still better than the current behaviour)
doc-not-needed