[improve][cli] Pulsar shell: add command to set/get property of a config #17651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc
nicoloboschi
changed the title
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
Sep 19, 2022
…fig (apache#17651) (cherry picked from commit 4ec1009)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In Pulsar shell you can only update the whole configuration but you can't modify it later. For instance, if I import a new config and then I want to enable a feature or a property, I need to read the config, copy, modify and update.
My use-case is that I want to enable custom commands in a quick way.
Modifications
config set-property -p <prop> -v <value> <config>It updates or creates a new entry in the config. If you modify the current config, the shell will reload applying the new config.
config get-property -p <prop> <config>Returns the current value for the property of the config
For example, now I can enable a cli extensions directly from the shell:
doc