[cleanup][broker][Modernizer] fix violations in pulsar-broker

[youzipi]

Master Issue: #12271 #16991

Motivation

Apply Maven Modernizer plugin to enforce we move away from legacy APIs.

Modifications

• fix violations in pulsar-broker package.

Verifying this change

This change is already covered by existing tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API: (no)
• The schema: (no)
• The default values of configurations: (no)
• The wire protocol: (no)
• The rest endpoints: (no)
• The admin cli options: (no)
• Anything that affects deployment: (no)

Documentation

• doc-not-needed

Matching PR in forked repository

PR in forked repository: youzipi#1

[youzipi]

@MarvinCai @tisonkun

[tisonkun]

Interesting. As we enable Modernizer for managed-ledger already, doesn't this file cause failure already?

[youzipi]

 /Users/mac/projects/source_code/pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription$3.java:-1: Prefer java.util.function.Predicate

here is the only one guava Predicate in PersistentSubscription, an anonymous class:

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java

Lines 558 to 563 in e73b298

	return cursor.scan(position, new Predicate<Entry>() {
	@Override
	public boolean apply(Entry entry) {
	if (log.isDebugEnabled()) {
	log.debug("found {}", entry);
	}

---

moderinzer use ASM to scan the class files and detect the latency usage.

current rule only detect implementing legacy interfaces, see gaul/modernizer-maven-plugin#1

I build a test case and debug it,
found that modernizer use a map to store all rules, and match with the class token by absolutely equal(not contains):

private final Map<String, Violation> violations;
...
Violation violation = violations.get(token); 
checkToken(token, violation, name, lineNumber);

actually, this case is detected in the interface list,
that is where the lineNumber=-1 from:

        for (String itr : interfaces) {
            Violation violation = violations.get(itr);
            checkToken(itr, violation, name, /*lineNumber=*/ -1);
        }

[tisonkun]

LGTM. One comment out of curiosity.

[youzipi]

@MarvinCai @codelipenghui

[MarvinCai]

/pulsarbot run-failure-checks