Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup][test]delete unnecessary variables in SubscriptionMessageDispatchThrottlingTest #17702

Merged
merged 1 commit into from
Sep 20, 2022
Merged

[cleanup][test]delete unnecessary variables in SubscriptionMessageDispatchThrottlingTest #17702

merged 1 commit into from
Sep 20, 2022

Conversation

guan46
Copy link
Contributor

@guan46 guan46 commented Sep 17, 2022 •
edited
Loading

Motivation

I found we declared some variables, but does not used these.

Modifications

Remove these unnecessary variables.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 17, 2022
@guan46 guan46 changed the title [cleanup][test]delete unnecessary variables in 类名 [cleanup][test]delete unnecessary variables in SubscriptionMessageDispatchThrottlingTest Sep 17, 2022
@Technoboy- Technoboy- added area/test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use labels Sep 19, 2022
@Technoboy- Technoboy- added this to the 2.12.0 milestone Sep 19, 2022
@mattisonchao mattisonchao merged commit 311ca90 into apache:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattisonchao mattisonchao mattisonchao approved these changes

@poorbarcode poorbarcode poorbarcode approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@AnonHxy AnonHxy AnonHxy approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

Assignees

@guan46 guan46

Labels
area/test doc-not-needed Your PR changes do not impact docs type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@guan46 @Technoboy- @AnonHxy @codelipenghui @poorbarcode @mattisonchao