Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][client] Unwrap completion exception for Lookup Services #17717

Merged
merged 2 commits into from
Sep 20, 2022
Merged

[fix][client] Unwrap completion exception for Lookup Services #17717

merged 2 commits into from
Sep 20, 2022

Conversation

codelipenghui
Copy link
Contributor

Motivation

The error messages look a little bit wired while I try to use pulsar-client to run some tests.

PulsarClientException: java.util.concurrent.CompletionException: io.netty.channel.AbstractChannel$AnnotatedConnectException

During the broker shutdown, the error logs like following

2022-09-19T11:37:56,215+0800 [pulsar-client-io-1-1] WARN  org.apache.pulsar.client.impl.ConnectionPool - Failed to open connection to localhost/<unresolved>:6650 : io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: localhost/127.0.0.1:6650
2022-09-19T11:37:56,215+0800 [pulsar-client-io-1-1] WARN  org.apache.pulsar.client.impl.ConnectionHandler - [persistent://public/default/test] [reader-23bc11015c] Error connecting to broker: org.apache.pulsar.client.api.PulsarClientException: java.util.concurrent.CompletionException: io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: localhost/127.0.0.1:6650
2022-09-19T11:37:56,215+0800 [pulsar-client-io-1-1] WARN  org.apache.pulsar.client.impl.ConnectionHandler - [persistent://public/default/test] [reader-23bc11015c] Could not get connection to broker: org.apache.pulsar.client.api.PulsarClientException: java.util.concurrent.CompletionException: io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: localhost/127.0.0.1:6650 -- Will try again in 0.736 s
2022-09-19T11:37:56,952+0800 [pulsar-timer-6-1] INFO  org.apache.pulsar.client.impl.ConnectionHandler - [persistent://public/default/test] [reader-23bc11015c] Reconnecting after connection was closed
2022-09-19T11:37:56,953+0800 [pulsar-client-io-1-1] WARN  org.apache.pulsar.client.impl.ConnectionPool - Failed to open connection to localhost/<unresolved>:6650 : io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: localhost/127.0.0.1:6650
2022-09-19T11:37:56,953+0800 [pulsar-client-io-1-1] WARN  org.apache.pulsar.client.impl.ConnectionHandler - [persistent://public/default/test] [reader-23bc11015c] Error connecting to broker: org.apache.pulsar.client.api.PulsarClientException: java.util.concurrent.CompletionException: io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: localhost/127.0.0.1:6650
2022-09-19T11:37:56,953+0800 [pulsar-client-io-1-1] WARN  org.apache.pulsar.client.impl.ConnectionHandler - [persistent://public/default/test] [reader-23bc11015c] Could not get connection to broker: org.apache.pulsar.client.api.PulsarClientException: java.util.concurrent.CompletionException: io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: localhost/127.0.0.1:6650 -- Will try again in 1.583 s

Modifications

Make the Lookup Services handle the completion exception property.

Documentation

  • doc-not-needed
    (Please explain why)

Matching PR in forked repository

PR in forked repository: codelipenghui#12

@codelipenghui codelipenghui self-assigned this Sep 19, 2022
@codelipenghui codelipenghui added this to the 2.12.0 milestone Sep 19, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 19, 2022
@codelipenghui codelipenghui added type/bug The PR fixed a bug or issue reported a bug area/client and removed doc-not-needed Your PR changes do not impact docs labels Sep 19, 2022
@codelipenghui codelipenghui changed the title [fix][broker] Unwrap completion exception for Lookup Services [fix][client] Unwrap completion exception for Lookup Services Sep 19, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 19, 2022
@codelipenghui codelipenghui reopened this Sep 20, 2022
@codelipenghui codelipenghui merged commit 320300c into apache:master Sep 20, 2022
@Technoboy- Technoboy- modified the milestones: 2.12.0, 2.11.0 Sep 20, 2022
Technoboy- pushed a commit that referenced this pull request Sep 20, 2022
@codelipenghui @Technoboy-
[fix][client] Unwrap completion exception for Lookup Services (#17717)
ee30b13
congbobo184 pushed a commit that referenced this pull request Nov 14, 2022
@codelipenghui
[fix][client] Unwrap completion exception for Lookup Services (#17717)
cc97adf 
(cherry picked from commit 320300c)
@congbobo184 congbobo184 added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Nov 14, 2022
@codelipenghui codelipenghui deleted the penghui/lookup-service-unwrap-completion-exception branch November 26, 2022 06:40
liangyepianzhou pushed a commit that referenced this pull request Dec 6, 2022
@codelipenghui @liangyepianzhou
[fix][client] Unwrap completion exception for Lookup Services (#17717)
a53c32a 
(cherry picked from commit 320300c)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Dec 6, 2022
@codelipenghui @nicoloboschi
[fix][client] Unwrap completion exception for Lookup Services (apache…
de7fd6a 
…#17717)

(cherry picked from commit 320300c)
(cherry picked from commit a53c32a)
congbobo184 pushed a commit that referenced this pull request Dec 7, 2022
@codelipenghui
[fix][client] Unwrap completion exception for Lookup Services (#17717)
acdb3e1 
(cherry picked from commit 320300c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattisonchao mattisonchao mattisonchao approved these changes

@shibd shibd shibd approved these changes

@coderzc coderzc coderzc approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

Assignees

@codelipenghui codelipenghui

Labels
area/client cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 cherry-picked/branch-2.11 doc-not-needed Your PR changes do not impact docs ready-to-test release/2.9.4 release/2.10.3 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
7 participants
@codelipenghui @Technoboy- @coderzc @shibd @mattisonchao @congbobo184 @liangyepianzhou