-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support setting bundle number for default namespace when set up cluster #17722
Conversation
"--web-service-url-tls", "https://127.0.0.1:8443", | ||
"--broker-service-url", "pulsar://127.0.0.1:6650", | ||
"--broker-service-url-tls","pulsar+ssl://127.0.0.1:6651", | ||
"--bundle-numbers", "64", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be confusing because if the namespace is already existing, it won't have any effect. Also it's not clear in the command line that this will be related to the public/default
namespace.
Another approach could be to remove the 16 bundles in the hardcoded from and instead just use the default number of bundles which is set in broker.conf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another approach could be to remove the 16 bundles in the hardcoded from and instead just use the default number of bundles which is set in
broker.conf
This is a better way.
d5039ac
to
1fb1dd3
Compare
checks in fork repo : aloyszhang#2 |
/pulsarbot run-failure-checks |
@merlimat PTAL, thanks |
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java
Outdated
Show resolved
Hide resolved
707378a
to
f58b11b
Compare
cc @merlimat |
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java
Outdated
Show resolved
Hide resolved
@codelipenghui PTAL, thanks |
After discussing with @codelipenghui, getting bundle numbers for default namespaces from So, adding a new option like |
Motivation
In the actual production environment, users may only use one default namespace (public/default).
The number of bundles in this namespace is a default value of 16.
In addition, the manually split bundle is complicated and auto-split may lead to unstable services.
We expect to set a relatively large number of bundles for the default namespace when the cluster is built.
Modifications
support setting bundle number for default namespace when setting up cluster metadata
and the bundle number is thedefaultNumberOfNamespaceBundles
frombroker.conf
and the bundle number passed by a new option like
--default-namespacs-bundles-numbers
Verifying this change
This change added tests and can be verified as follows:
ClusterMetadataSetupTest.testSetupBundleForNamespaces
Documentation
doc-not-needed
(Please explain why)
PR in for repository
aloyszhang#2