[fix][CI] Fix issues with approval solution for GitHub Actions #17723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The approval solution doesn't work as expected by approving the PR
or by adding the ready-to-test label and adding a comment
"/pulsarbot rerun-failure-checks".
- Fix the ready-to-test label check:
- Refresh PR labels when re-running workflow
- when re-running, the event JSON remains the same. The API
must be used to fetch the up-to-date JSON for the PR.
- Fix the PR approval check:
- set GITHUB_TOKEN for script so that retrieving the approval status could work
lhotari
requested review from
codelipenghui,
nicoloboschi and
michaeljmarshall
|
https://github.com/apache/pulsar/actions/runs/3084722603/jobs/4987198213#step:5:9 demonstrates that these changes are able to retrieve the approval status: |
michaeljmarshall
approved these changes
Sep 19, 2022
|
/pulsarbot rerun-failure-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Additional context
The workaround until this PR is merged is to add a "ready-to-test" label to the PR and then close & reopen the PR.
Modifications
Fix the ready-to-test label check:
Fix the PR approval check:
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
PR in forked repository: lhotari#87