Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][doc] fix schema get value doc problem #17740

Merged

Conversation

congbobo184
Copy link
Contributor

Motivation

fix doc for consumer receive().getValue API

Modifications

Message<User> message = consumer.receive();
User user = message.getValue();

this is the right way
but doc is

User use = consumer.receive();

so change to

User user = consumer.receive().getValue();

@congbobo184 congbobo184 requested review from urfreespace, Anonymitaet and momo-jun and removed request for urfreespace September 20, 2022 09:31
@congbobo184 congbobo184 self-assigned this Sep 20, 2022
@congbobo184 congbobo184 added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Sep 20, 2022
@congbobo184 congbobo184 added this to the 2.11.0 milestone Sep 20, 2022
@congbobo184 congbobo184 added area/schema doc-required Your PR changes impact docs and you will update later. labels Sep 20, 2022
@github-actions github-actions bot added doc-label-missing and removed doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. doc-required Your PR changes impact docs and you will update later. labels Sep 20, 2022
@github-actions
Copy link

@congbobo184 Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@Technoboy- Technoboy- added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-label-missing labels Sep 21, 2022
@Technoboy- Technoboy- merged commit dba9c08 into apache:master Sep 21, 2022
@github-actions github-actions bot added doc-label-missing and removed doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants