Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][CI] Don't run CI when PR is in draft status or isn't mergeable #17749

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Sep 20, 2022

Motivation

Pulsar CI shouldn't run builds for PRs which are in draft status or aren't mergeable.

Modifications

Add additional checks to check draft status and mergeable status.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Matching PR in forked repository

PR in forked repository: lhotari#89

@lhotari lhotari force-pushed the lh-block-ci-when-draft-or-not-mergeable branch from 18fbb78 to 641d2ad Compare September 20, 2022 16:29
Copy link
Member

@michaeljmarshall michaeljmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once we get the CI stable, it'd be good to have a document describing when to expect tests to run.

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 20, 2022
@merlimat merlimat merged commit 782764f into apache:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants