[feat][build] Print out more info for bin/pulsar version #17752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
added
type/feature
lhotari
approved these changes
Sep 20, 2022
|
/pulsarbot rerun-failure-checks |
1 task
Technoboy-
approved these changes
Sep 21, 2022
michaeljmarshall
added a commit
to datastax/pulsar
that referenced
this pull request
Sep 21, 2022
### Motivation The current `bin/pulsar version` script only prints out the version string. When running custom builds of Pulsar, this is sometimes not enough to know which version you have. Since the `PulsarVersion` class already has more information, I propose we print out all of its information in the same format that the broker logs the information. Here is a sample output for this specific PR: ```shell $ bin/pulsar version Current version of pulsar is: 2.11.0-SNAPSHOT Git Revision 4414e3d Git Branch print-more-version-info Built by Michael Marshall <[email protected]> on mmarshall-rmbp16 at 2020-01-22T09:10:15-0600 ``` ### Modifications * Add more output to the `bin/pulsar version` command. ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Documentation - [x] `doc-not-needed` (Please explain why) ### Matching PR in forked repository PR in forked repository: michaeljmarshall#3 (cherry picked from commit 2d2a0b8)
michaeljmarshall
added a commit
to datastax/pulsar
that referenced
this pull request
Sep 21, 2022
### Motivation The current `bin/pulsar version` script only prints out the version string. When running custom builds of Pulsar, this is sometimes not enough to know which version you have. Since the `PulsarVersion` class already has more information, I propose we print out all of its information in the same format that the broker logs the information. Here is a sample output for this specific PR: ```shell $ bin/pulsar version Current version of pulsar is: 2.11.0-SNAPSHOT Git Revision 4414e3d Git Branch print-more-version-info Built by Michael Marshall <[email protected]> on mmarshall-rmbp16 at 2020-01-22T09:10:15-0600 ``` ### Modifications * Add more output to the `bin/pulsar version` command. ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Documentation - [x] `doc-not-needed` (Please explain why) ### Matching PR in forked repository PR in forked repository: michaeljmarshall#3 (cherry picked from commit 2d2a0b8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current
bin/pulsar versionscript only prints out the version string. When running custom builds of Pulsar, this is sometimes not enough to know which version you have. Since thePulsarVersionclass already has more information, I propose we print out all of its information in the same format that the broker logs the information.Here is a sample output for this specific PR:
Modifications
bin/pulsar versioncommand.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
doc-not-needed(Please explain why)
Matching PR in forked repository
PR in forked repository: michaeljmarshall#3