[improve][CI] Support GitHub Actions approval solution on maintenance branches #17770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
force-pushed
the
lh-pulsar-ci-approval-maintenance-branches
branch
from
f20ceea to
67f5b62
Compare
|
This is not relevant at the moment, but will be helpful if we later on expand the approval solution to cover maintenance branches like branch-2.10 or older where builds get currently triggered for pull requests. |
nicoloboschi
approved these changes
Sep 26, 2022
|
/pulsarbot rerun-failure-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The GitHub Actions approval solution is also useful for maintenance branches to cut unnecessary builds.
branch-2.11 contains a similar workflow as master branch and it will also be useful to port the approval to other
maintenance branches as a way to prevent unnecessary builds.
Modifications
Remove the hard coding of master branch in the script which generates the link for opening a PR in your fork.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
PR in forked repository: lhotari#90