Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup][admin]cleanup unused sync method in NamespacesBase #17778

Merged
merged 1 commit into from
Sep 26, 2022
Merged

[cleanup][admin]cleanup unused sync method in NamespacesBase #17778

merged 1 commit into from
Sep 26, 2022

Conversation

AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Sep 21, 2022 •
edited
Loading

Motivation

Cleanup unused sync method in NamespacesBase

Modifications

Removing validatePolicies and internalSetTopicDispatchRate

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Matching PR in forked repository

PR in forked repository: AnonHxy#2

@AnonHxy AnonHxy mentioned this pull request Sep 21, 2022
Closed
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 21, 2022
@AnonHxy AnonHxy self-assigned this Sep 22, 2022
@AnonHxy AnonHxy added the type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use label Sep 22, 2022
Jason918
Jason918 approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Sep 22, 2022

/pulsarbot ready-to-test

@Technoboy- Technoboy- closed this Sep 26, 2022
@Technoboy- Technoboy- reopened this Sep 26, 2022
@Technoboy- Technoboy- added this to the 2.12.0 milestone Sep 26, 2022
@Technoboy- Technoboy- merged commit 691e468 into apache:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@HQebupt HQebupt HQebupt approved these changes

@Jason918 Jason918 Jason918 approved these changes

Assignees

@AnonHxy AnonHxy

Labels
doc-not-needed Your PR changes do not impact docs ready-to-test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AnonHxy @Jason918 @HQebupt @Technoboy-