-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add developers-landing page to sidebars #17780
Conversation
Signed-off-by: tison <[email protected]>
Hi tison! This page does not require sidebar links. The landing pages I'll be creating PRs for over the next few days will not require a sidebar link. These pages serve only as a connection point between the content blocks on the main documentation page and the topics. No additional navigation is needed. |
@DaveDuggins this patch doesn't add a new entry but reuse the "development" entry. If we don't add it to the sidebars, how can users find the page? Only by entering the exact url? It seems unreasonable. |
@DaveDuggins OK. I see the link from the original patch. Let me show you the result of this patch in preview later today. |
cc @DaveDuggins Current: Screen.Recording.2022-09-22.at.09.24.43.movPreview with this patch: Screen.Recording.2022-09-22.at.09.26.32.mov |
ping @DaveDuggins @Anonymitaet @momo-jun @urfreespace for another turn. |
No, by clicking the appropriate topic box on the main documentation page. These landing pages only serve as a bridge to the related articles linked from the content blocks on the main doc page. |
@DaveDuggins Yep. Please read the following comment for preview. This change won't break existing things and as an improvement. |
@DaveDuggins @momo-jun @urfreespace @Anonymitaet shall we merge this patch now? |
This is a followup to #17284.
cc @DaveDuggins @Anonymitaet @momo-jun @urfreespace
Documentation
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)
Matching PR in forked repository
docs only change