[fix][doc]fix comments for exposeManagedLedgerMetricsInPrometheus field #17792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HQebupt
approved these changes
Sep 22, 2022
|
The title |
4 tasks
Pomelongan
changed the title
AnonHxy
approved these changes
Sep 22, 2022
|
/pulsarbot ready-to-test |
Pomelongan
force-pushed
the
fix_comment
branch
from
6afa530 to
204e112
Compare
|
|
@Jason918 PTAL |
Jason918
pushed a commit
that referenced
this pull request
Sep 26, 2022
(cherry picked from commit 550c0e7)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 28, 2022
congbobo184
pushed a commit
that referenced
this pull request
Nov 8, 2022
(cherry picked from commit 550c0e7)
congbobo184
pushed a commit
that referenced
this pull request
Nov 30, 2022
(cherry picked from commit 550c0e7)
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The default value of the exposeManagedLedgerMetricsInPrometheus field is true, but the comment says that the default value is false.
Modifications
Correct the comment of exposeManagedLedgerMetricsInPrometheus field.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
PR in forked repository: Pomelongan#1