docs: Updating Python installation section #17796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
github-actions
bot
added
the
doc
tisonkun
commented
Sep 22, 2022
Comment on lines
-53
to
-63
| ### Install from source | ||
|
|
||
| To install the `pulsar-client` library by building from source, follow [instructions](client-libraries-cpp.md#compilation) and compile the Pulsar C++ client library. That builds the Python binding for the library. | ||
|
|
||
| To install the built Python bindings: | ||
|
|
||
| ```shell | ||
| git clone https://github.com/apache/pulsar | ||
| cd pulsar/pulsar-client-cpp/python | ||
| sudo python setup.py install | ||
| ``` |
There was a problem hiding this comment.
This is simply incorrect. We should update the doc in README.md under pulsar-client-cpp and add back this section to guide users there.
There was a problem hiding this comment.
It's really complex to build the Python client "correctly" from source right now. See #17468.
|
Preview should be almost the same (except style) with the render md version:
|
tisonkun
commented
Sep 22, 2022
tisonkun
commented
Sep 22, 2022
Signed-off-by: tison <[email protected]>
RobertIndie
approved these changes
Sep 22, 2022
Anonymitaet
reviewed
Sep 23, 2022
Anonymitaet
reviewed
Sep 23, 2022
shibd
approved these changes
Sep 23, 2022
Demogorgon314
approved these changes
Sep 23, 2022
BewareMyPower
approved these changes
Sep 23, 2022
|
@Anonymitaet comments resolved. Could you give this patch another turn? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @BewareMyPower @shibd @RobertIndie @Demogorgon314 @Anonymitaet
This closes #17794.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
N/A