Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add ceveat to Pulsar SQL overview and update Presto to Trino #17798

Merged
merged 5 commits into from
Sep 23, 2022

Conversation

tisonkun
Copy link
Member

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Matching PR in forked repository

N/A

cc @nicoloboschi @eolivelli @codelipenghui @merlimat @MarvinCai @momo-jun

@@ -117,61 +116,3 @@ presto> select * from pulsar."public/default".generator_test;
```

You can query the mock data.

## Query your own data
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confusing content. Removed.

It's possible to write a new example but we should remove confusing content at least.

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Sep 22, 2022
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicoloboschi nicoloboschi merged commit d14a3bd into apache:master Sep 23, 2022
@tisonkun tisonkun deleted the sql-docs branch September 24, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] Add ceveat of PIP-200 to the Pulsar SQL overview page
2 participants