[fix][flaky-test]PersistentSubscriptionTest.testCanAcknowledgeAndCommitForTransaction #17845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After discussion with @congbobo184 , the scenario of this test was covered by |
congbobo184
approved these changes
Sep 27, 2022
poorbarcode
force-pushed
the
flaky/testCanAcknowledgeAndCommitForTransaction
branch
from
cca82b7 to
60a3d62
Compare
|
/pulsarbot rerun-failure-checks |
1 similar comment
|
/pulsarbot rerun-failure-checks |
poorbarcode
deleted the
flaky/testCanAcknowledgeAndCommitForTransaction
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Motivation
Concurrent execution of these two instructions will throw an exception:
In this test,
cursorMocktriggers this error.Modifications
make "binding the new mock behavior" always running after "all methods execute finish"
Documentation
doc-not-neededMatching PR in forked repository
PR in forked repository: