[fix][flaky-test] Fix and improve LookupRetryTest

[coderzc]

Fixes #17785

Motivation

The failureMap need to be clear after run per unit test.

Modifications

Clear failureMap after run per unit test, and only run once setup()/cleanup() to reduce execution time.

Documentation

• doc-required
  (Your PR needs to update docs and you will update later)

• doc-not-needed
  (Please explain why)

• doc
  (Your PR contains doc changes)

• doc-complete
  (Docs have been already added)

Matching PR in forked repository

PR in forked repository: coderzc#6

[tisonkun]

LGTM. Nice catch!

[tisonkun]

@coderzc although, can you explain a bit about how this patch fix the original issue?

The original failure reports:

  Error:  testCloseConnectionOnBrokerRejectedRequest(org.apache.pulsar.client.impl.LookupRetryTest)  Time elapsed: 2.146 s  <<< FAILURE!
  java.lang.AssertionError: expected [2] but found [1]
  	at org.testng.Assert.fail(Assert.java:99)
  	at org.testng.Assert.failNotEquals(Assert.java:1037)
  	at org.testng.Assert.assertEqualsImpl(Assert.java:140)
  	at org.testng.Assert.assertEquals(Assert.java:122)
  	at org.testng.Assert.assertEquals(Assert.java:907)
  	at org.testng.Assert.assertEquals(Assert.java:917)
  	at org.apache.pulsar.client.impl.LookupRetryTest.testCloseConnectionOnBrokerRejectedRequest(LookupRetryTest.java:217)

That doesn't directly related to the hash map.

[coderzc]

@coderzc although, can you explain a bit about how this patch fix the original issue?

The original failure reports:

  Error:  testCloseConnectionOnBrokerRejectedRequest(org.apache.pulsar.client.impl.LookupRetryTest)  Time elapsed: 2.146 s  <<< FAILURE!
  java.lang.AssertionError: expected [2] but found [1]
  	at org.testng.Assert.fail(Assert.java:99)
  	at org.testng.Assert.failNotEquals(Assert.java:1037)
  	at org.testng.Assert.assertEqualsImpl(Assert.java:140)
  	at org.testng.Assert.assertEquals(Assert.java:122)
  	at org.testng.Assert.assertEquals(Assert.java:907)
  	at org.testng.Assert.assertEquals(Assert.java:917)
  	at org.apache.pulsar.client.impl.LookupRetryTest.testCloseConnectionOnBrokerRejectedRequest(LookupRetryTest.java:217)

That doesn't directly related to the hash map.

Oh, I haven't found the root cause of the original case for the time being, but when I have repeatedly executed testCloseConnectionOnBrokerRejectedRequest many times, if don‘t clearfailureMap will cause similar problems.

[Jason918]

LGTM

[tisonkun]

/pulsarbot run-failure-checks

[coderzc]

/pulsarbot run-failure-checks