fix: SqliteJdbcSinkTest close in order

[tisonkun]

This closes #17713.

Documentation

• doc-required
  (Your PR needs to update docs and you will update later)

• doc-not-needed
  (Please explain why)

• doc
  (Your PR contains doc changes)

• doc-complete
  (Docs have been already added)

Matching PR in forked repository

PR in forked repository: tisonkun#3

[tisonkun]

cc @lhotari @poorbarcode

The root cause is that we run connection.commit concurrently in flush and close so it's possible that:

db.exec("commit;") // in flush
db.exec("commit;") // in close
db.exec("begin;") // in flush

so the second call failed with "no transaction is active".

The last commit in this patch can be overkill but it's a strong guarantee that we don't run into this situation (executor.shutdown doesn't cancel pending/running scheduled tasks). I'm glad to learn if we have a more lightweight solution (in-place sync for connection.commit? It looks a bit hacky for me XD).

NOTE: Before and after the last commit, all tests pass in about 3 seconds, no regression.

[tisonkun]

I think I can use shutdown + awaitTermination here to simplify the code.

[nicoloboschi]

+1

[nicoloboschi]

/pulsarbot rerun-failure-checks

[tisonkun]

/pulsarbot rerun-failure-checks

[lhotari]

Good work!