[fix][flaky-test]ProxyConnectionThrottlingTest.testInboundConnection

[poorbarcode]

Fixes:

• Flaky-test: ProxyConnectionThrottlingTest.testInboundConnection #17665

Motivation

this test is executed as follows:

1. set max connection limited 4
2. create two clients and two producers, this will create 4 connections
3. try to create another client and producer, this will fail cause of reaches the max connections count limit

But the execution logic of step-3 is like this:

1. increment DefaultConnectionController.totalConnectionNum
2. if the state State.REACH_MAX_CONNECTION_PER_IP founded, do close connection which will decrement DefaultConnectionController.totalConnectionNum

Then the problem is that the connection closes was executed asynchronously(see code below), if the main thread executes fast enough, the assert Assert.assertEquals(ConnectionController.DefaultConnectionController.getTotalConnectionNum(), 4) will fail, because the last connection has not close finish.

pulsar/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java

Lines 153 to 165 in bde5ac7

	public void channelRegistered(ChannelHandlerContext ctx) throws Exception {
	super.channelRegistered(ctx);
	ProxyService.ACTIVE_CONNECTIONS.inc();
	SocketAddress rmAddress = ctx.channel().remoteAddress();
	ConnectionController.State state = connectionController.increaseConnection(rmAddress);
	if (!state.equals(ConnectionController.State.OK)) {
	ctx.writeAndFlush(Commands.newError(-1, ServerError.NotAllowedError,
	state.equals(ConnectionController.State.REACH_MAX_CONNECTION)
	? "Reached the maximum number of connections"
	: "Reached the maximum number of connections on address" + rmAddress))
	.addListener(result -> ctx.close());
	ProxyService.REJECTED_CONNECTIONS.inc();
	}

Modifications

Change the assertion logic to executed using Awaitility

Documentation

• doc-not-needed

Matching PR in forked repository

PR in forked repository:

• [ci-run][fix][flaky-test]ProxyConnectionThrottlingTest.testInboundConnection poorbarcode/pulsar#17

[mattisonchao]

Thanks a lot!!