Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][loadbalance] Fix the wrong NIC speed rate unit. #17890

Merged
merged 1 commit into from
Sep 30, 2022
Merged

[fix][loadbalance] Fix the wrong NIC speed rate unit. #17890

merged 1 commit into from
Sep 30, 2022

Conversation

mattisonchao
Copy link
Member

Fixes #17885

Master Issue: #17885

Motivation

See #17885, And I checked other usages.

Modifications

  • Change rate unit to Mbit.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Matching PR in forked repository

PR in forked repository:

@mattisonchao mattisonchao added this to the 2.12.0 milestone Sep 29, 2022
@mattisonchao mattisonchao self-assigned this Sep 29, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 29, 2022
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch.

It looks like we should port this to 2.10.2 before we release it.

@Jason918

@mattisonchao
Copy link
Member Author

Hi, @eolivelli
It just affects 2.11. and introduced by #15435.

@mattisonchao mattisonchao reopened this Sep 29, 2022
@mattisonchao mattisonchao added the release/blocker Indicate the PR or issue that should block the release until it gets resolved label Sep 29, 2022
@mattisonchao mattisonchao reopened this Sep 29, 2022
@mattisonchao mattisonchao merged commit fb7307d into apache:master Sep 30, 2022
@mattisonchao mattisonchao deleted the fix_wrong_rate_unit branch September 30, 2022 03:38
mattisonchao added a commit that referenced this pull request Sep 30, 2022
@mattisonchao mattisonchao removed the release/blocker Indicate the PR or issue that should block the release until it gets resolved label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect TotalNicLimit collected by pulsar
4 participants