[fix][flaky-test]NegativeAcksTest.testNegativeAcksWithBatchAckEnabled #17893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
requested review from
Technoboy-,
codelipenghui,
congbobo184,
gaoran10,
liangyepianzhou and
eolivelli
congbobo184
approved these changes
Sep 30, 2022
codelipenghui
approved these changes
Sep 30, 2022
recover timeout to `10s`. because I rerun it locally again, cost only 5S
Technoboy-
approved these changes
Sep 30, 2022
lhotari
pushed a commit
that referenced
this pull request
Aug 9, 2024
…#17893) Fixes: #16864 ### Motivation I think it is a wrong configuration(`ackTimeout 1s`) when writing the code, the original design is set `negativeAckRedeliveryDelay 1s` The process expects: - send 10 messages in one batch - submit a batch. - receive 10 messages, do negative acknowledge - after `1s`, will trigger `redelivery` - receive 10 messages again The real process: - send 1 message - Reach the batch time limit, and submit a batch. return `msgId_1` - send 9 messages in another batch - submit a batch. return `msgId_2` - receive 10 messages, do negative acknowledge - push the `msgId_1` to `negativeAcksTracker` - push the `msgId_2` to `unAckedMessageTracker` - after `1s`, will trigger redelivery `msgId_2` by `unAckedMessageTracker` - receive 9 messages( `msgId_2` ) again - after `60s`, will trigger redelivery `msgId_1` by `negativeAcksTracker`. <strong>(High light)</strong> Test execution timeout! - receive 1 messages( `msgId_1` ) again ### Modifications - remove conf: `ackTimeout` - set `negativeAckRedeliveryDelay 1s` ### Documentation - [x] `doc-not-needed` ### Matching PR in forked repository PR in forked repository: - poorbarcode#18 (cherry picked from commit 85b1138)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16864
Motivation
I think it is a wrong configuration(
ackTimeout 1s) when writing the code, the original design is setnegativeAckRedeliveryDelay 1sThe process expects:
1s, will triggerredeliveryThe real process:
msgId_1msgId_2msgId_1tonegativeAcksTrackermsgId_2tounAckedMessageTracker1s, will trigger redeliverymsgId_2byunAckedMessageTrackermsgId_2) again60s, will trigger redeliverymsgId_1bynegativeAcksTracker. (High light) Test execution timeout!msgId_1) againModifications
ackTimeoutnegativeAckRedeliveryDelay 1sDocumentation
doc-not-neededMatching PR in forked repository
PR in forked repository: