Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make BookieId work with PulsarRegistrationDriver (#17762)" #17914

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

eolivelli
Copy link
Contributor

This reverts commit 8d7ac33.

Fixes #17913

Fixes #

Master Issue: #

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Matching PR in forked repository

PR in forked repository: <!-- ENTER URL HERE

After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.

apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.

The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.

-->

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

@eolivelli Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@eolivelli eolivelli self-assigned this Oct 3, 2022
@tisonkun
Copy link
Member

tisonkun commented Oct 4, 2022

@codelipenghui @eolivelli could you help with checking the doc-not-needed checkbox here? If we just ignore the doc-label-missing label, it's worthless to maintain.

@eolivelli eolivelli merged commit 9d6c34e into apache:master Oct 4, 2022
@eolivelli eolivelli deleted the impl/revert-bookieid branch October 4, 2022 06:22
eolivelli added a commit that referenced this pull request Oct 4, 2022
eolivelli added a commit that referenced this pull request Oct 4, 2022
@Technoboy- Technoboy- added this to the 2.12.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Deadlock while reading Schema from BookKeeper
5 participants