[fix][testclient] Fix proxyProtocol parsing when value is empty, fix invalid property name #17930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…invalid property name
This was referenced Oct 4, 2022
nicoloboschi
approved these changes
Oct 4, 2022
tisonkun
approved these changes
Oct 4, 2022
4 tasks
5 tasks
BewareMyPower
approved these changes
Oct 4, 2022
Thank you for the fix @lhotari . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
An invalid change introduced to the CI workflow in PR #17881 allowed merging PRs that contained test failures.
PR #17862 contained some minor gaps in the changes that were introduced and had failing tests.
This got merged because the "required checks" check was broken in CI.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: lhotari#94