Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc]Make node and c++ client compatibility table a link to github #17935

Merged
merged 1 commit into from
Oct 5, 2022
Merged

[doc]Make node and c++ client compatibility table a link to github #17935

merged 1 commit into from
Oct 5, 2022

Conversation

hrsakai
Copy link
Contributor

@hrsakai hrsakai commented Oct 5, 2022 •
edited
Loading

Fixes #17786

Motivation

  • We want to make compatibility table single source because it is hard to keep all of them up-to-date.

Modifications

  • Make node and c++ client compatibility table a link to github.

Documentation

  • doc

@hrsakai hrsakai added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Oct 5, 2022
@hrsakai hrsakai added this to the 2.12.0 milestone Oct 5, 2022
@hrsakai hrsakai self-assigned this Oct 5, 2022
tisonkun
tisonkun approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun
Copy link
Member

tisonkun commented Oct 5, 2022

cc @BewareMyPower @merlimat @Anonymitaet

@tisonkun
Copy link
Member

tisonkun commented Oct 5, 2022

@hrsakai please update the PR description. This should close #17786

@hrsakai hrsakai mentioned this pull request Oct 5, 2022
Closed
2 tasks
@BewareMyPower BewareMyPower merged commit ca052d4 into apache:master Oct 5, 2022
@hrsakai hrsakai deleted the fix-nodejs-doc branch October 5, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@BewareMyPower BewareMyPower BewareMyPower approved these changes

Assignees

@hrsakai hrsakai

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

[Doc] Inconsistent npm compatibility across multiple sites
3 participants
@hrsakai @tisonkun @BewareMyPower